andrewrk / andrewrk/node-diacritics

.find() method to retrieve all the group of diacritics from a specific char

Aperta
#20 7 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
270
Fork
32
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Hi @andrewrk,

What do you think about this? Right now i'm facing a case where i need to have a group of all possible diacritics from a specific char. I remembered about your great list of diacritics, and that your package is named as 'diacritics', and not something like 'remove-diacritics', so i thought that would be better to extend it with one more method instead of create another package.

I already created the new method:

```
function findDiacritics(chr) {

var diacriticsFound = replacementList.find( o => o.base == chr || o.chars.indexOf(chr) >= 0 );
return (diacriticsFound)? diacriticsFound.base + diacriticsFound.chars : null;

}
```

If you think it is ok, i can send you a pull request.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.