andrewrk / andrewrk/node-diacritics

.find() method to retrieve all the group of diacritics from a specific char

Open
#20 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
270
Forks
32
PR merge metrics
No merged PRs in 30d

Description

Hi @andrewrk,

What do you think about this? Right now i'm facing a case where i need to have a group of all possible diacritics from a specific char. I remembered about your great list of diacritics, and that your package is named as 'diacritics', and not something like 'remove-diacritics', so i thought that would be better to extend it with one more method instead of create another package.

I already created the new method:

```
function findDiacritics(chr) {

var diacriticsFound = replacementList.find( o => o.base == chr || o.chars.indexOf(chr) >= 0 );
return (diacriticsFound)? diacriticsFound.base + diacriticsFound.chars : null;

}
```

If you think it is ok, i can send you a pull request.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.