andrewdavey / andrewdavey/vogue
Vogue is incorrect in assuming it's the last script in scripts array
- Langage dominant
- JavaScript
- Étoiles
- 267
- Forks
- 36
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
I am getting errors like this:
"NetworkError: 404 NOT FOUND - http://127.0.0.1:8000/products/undefinedsocket.io/socket.io.js"
The problem lies in getScriptInfo() in vogue-client.js
it assumes the Vogue script will be the last one in the array returned by `document.getElementsByTagName("script")` but because it appends itself to the ... and common practice is now to put all your scripts at the bottom of the (see html5 boilerplate etc)... so it is not selecting the Vogue script, it's grabbing my Google Analytics script block instead.
It really needs to look for `vogue-client.js` specifically.
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.