andrewdavey / andrewdavey/vogue

Vogue is incorrect in assuming it's the last script in scripts array

Open
#31 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
267
Forks
36
PR merge metrics
No merged PRs in 30d

Description

I am getting errors like this:
"NetworkError: 404 NOT FOUND - http://127.0.0.1:8000/products/undefinedsocket.io/socket.io.js"

The problem lies in getScriptInfo() in vogue-client.js

it assumes the Vogue script will be the last one in the array returned by `document.getElementsByTagName("script")` but because it appends itself to the ... and common practice is now to put all your scripts at the bottom of the (see html5 boilerplate etc)... so it is not selecting the Vogue script, it's grabbing my Google Analytics script block instead.

It really needs to look for `vogue-client.js` specifically.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.