andreagrandi / andreagrandi/draftomen

Parse human-draft picks and completion

オープン
#259 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
draftomen enhancement size: M
主要言語
Python
スター
0
フォーク
0
平均マージ
1時間 21分
マージ済み PR(30日)
188

説明

## Problem

The parser only consumes bot-draft pick messages and enforces exactly one selected card. Premier, Traditional, and Pick-Two use `EventPlayerDraftMakePick`, and private Pick-Two evidence directly shows two `GrpIds` in one submission plus a distinct completion message.

## Proposed change

Parse human-draft pick submissions and completion according to the detected format/rules contract. Treat `GrpIds` as a collection, correlate submissions with pack notifications, and handle missing/duplicate/truncated records without format guessing from cardinality when metadata is present.

## Acceptance Criteria

- [ ] Premier and Traditional one-card submissions produce one-card logical picks.
- [ ] Pick-Two two-card submissions retain both IDs in one logical pick.
- [ ] Explicit event metadata wins over payload-cardinality heuristics.
- [ ] Human-draft completion is recognized from observed messages without applying Quick Draft's 42-card inference globally.
- [ ] Missing submissions, failed-pick gaps, duplicate responses, and truncated envelopes do not crash or fabricate picks.
- [ ] Unknown human-draft events fail safely without contaminating the active draft.
- [ ] Hand-authored synthetic fixtures cover all supported message shapes; raw logs remain private.
- [ ] Existing Quick Draft behavior and focused parser tests pass, with a changelog entry.

## Scope notes

No persistence redesign beyond Child 2 and no frontend behavior.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

調査の方向性

Start with the parser and existing focused parser tests, then use hand-authored synthetic fixtures to cover the supported message shapes described in the acceptance criteria. Done means human-draft submissions and completion are handled safely, missing or malformed records do not create false picks, existing Quick Draft behavior still passes, and the changelog is updated.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
python
領域
backend, testing
issue の種類
機能追加
難易度
5/5
見積もり時間
1週間以上
活発さ
活発
明瞭さ
おおむね明確
初心者へのやさしさ
45/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。