amplitude / amplitude/Amplitude-TypeScript

`Previous Page Type` incorrectly stated as `external` when `Previous Page Location` is a subdomain in the same domain

Đang mở
#1,400 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
bug
Ngôn ngữ chính
TypeScript
Star
180
Fork
68
Merge trung bình
3 ngày 1 giờ
Pull request đã merge (30 ngày)
29

Mô tả

## Expected Behavior

`Previous Page Type` event property should be `internal` when the previous page location is still in the same domain.

Example:
```
[Amplitude] Page URL = https://my.bigcartel.biz/login
[Amplitude] Previous Page Location = https://app.bigcartel.biz/
[Amplitude] Previous Page Type = internal
```

## Current Behavior

`Previous Page Type` event property is incorrectly stating `external` when the previous page is still in our domain.

Example just now:
```
[Amplitude] Page URL = https://my.bigcartel.biz/login
[Amplitude] Previous Page Location = https://app.bigcartel.biz/
[Amplitude] Previous Page Type = external
```

## Comments

Should this logic depend on the setting for `excludeReferrers`? It's tough to not have control over what is considered "internal" vs "external" making this new `Previous Page Type` property not helpful.

Perhaps domains matching the `excludeReferrers` should mean its `internal` otherwise `external` if a referrer defined, then fallback to `direct` when no referrer?

## Environment

- JS SDK Version:
- `@amplitude/analytics-browser@2.29.0`
- `@amplitude/plugin-web-attribution-browser@2.1.92`
- `@amplitude/analytics-client-common@2.4.11` (contains the bug)
- Installation Method: NPM
- Browser and Version: All browsers
- Next.js Version: 15.1.6

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.