amplitude / amplitude/Amplitude-TypeScript

`Previous Page Type` incorrectly stated as `external` when `Previous Page Location` is a subdomain in the same domain

Abierto
#1,400 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug
Lenguaje dominante
TypeScript
Estrellas
180
Forks
68
Merge medio
3 d 1 h
PR fusionados (30 d)
29

Descripción

## Expected Behavior

`Previous Page Type` event property should be `internal` when the previous page location is still in the same domain.

Example:
```
[Amplitude] Page URL = https://my.bigcartel.biz/login
[Amplitude] Previous Page Location = https://app.bigcartel.biz/
[Amplitude] Previous Page Type = internal
```

## Current Behavior

`Previous Page Type` event property is incorrectly stating `external` when the previous page is still in our domain.

Example just now:
```
[Amplitude] Page URL = https://my.bigcartel.biz/login
[Amplitude] Previous Page Location = https://app.bigcartel.biz/
[Amplitude] Previous Page Type = external
```

## Comments

Should this logic depend on the setting for `excludeReferrers`? It's tough to not have control over what is considered "internal" vs "external" making this new `Previous Page Type` property not helpful.

Perhaps domains matching the `excludeReferrers` should mean its `internal` otherwise `external` if a referrer defined, then fallback to `direct` when no referrer?

## Environment

- JS SDK Version:
- `@amplitude/analytics-browser@2.29.0`
- `@amplitude/plugin-web-attribution-browser@2.1.92`
- `@amplitude/analytics-client-common@2.4.11` (contains the bug)
- Installation Method: NPM
- Browser and Version: All browsers
- Next.js Version: 15.1.6

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.