amethyst / amethyst/specs

Consider inlcuding the entity generation in ComponentEvent

Aperta
#720 1 commento 3 reazioni 0 assegnatari Vedi su GitHub
feature-request
Lingua principale
Rust
Stelle
2.6k
Fork
215
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

## Description
Including the entity generation instead of just the index within the [component event](https://docs.rs/specs/0.16.1/specs/storage/enum.ComponentEvent.html) used by `FlaggedStorage`.

## Motivation
When an entity is deleted removal events are generated for its components in `FlaggedStorage`s. If another entity is created at the same index there is no way to tell if the removed components are from the old entity or the new one. When using this for network syncing the means we end up sending useless component removed events (since we can't be sure they don't apply to the new entity).

## Drawbacks
This would be a breaking change and would increase the size of `ComponentEvent`

## Unresolved questions

---
I would be happy to implement this if approved.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.