amethyst / amethyst/specs

Consider inlcuding the entity generation in ComponentEvent

Offen
#720 1 Kommentar 3 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
feature-request
Vorherrschende Sprache
Rust
Sterne
2.6k
Forks
215
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

## Description
Including the entity generation instead of just the index within the [component event](https://docs.rs/specs/0.16.1/specs/storage/enum.ComponentEvent.html) used by `FlaggedStorage`.

## Motivation
When an entity is deleted removal events are generated for its components in `FlaggedStorage`s. If another entity is created at the same index there is no way to tell if the removed components are from the old entity or the new one. When using this for network syncing the means we end up sending useless component removed events (since we can't be sure they don't apply to the new entity).

## Drawbacks
This would be a breaking change and would increase the size of `ComponentEvent`

## Unresolved questions

---
I would be happy to implement this if approved.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.