amethyst / amethyst/rustrogueliketutorial

Missing information on removing `Monster`

未關閉
#222 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Rust
星號
970
分支
166
PR 合併指標
30 天內沒有已合併 PR

描述

https://github.com/amethyst/rustrogueliketutorial/blob/33872fe582f226178436847e1f74eafcbf9c0d1a/book/src/chapter_57.md?plain=1#L1509

At this point in the tutorial, `Monster` is still used in `inventory_system`.
From what I see in the code repository, checks on wether the target is a monster or not have been removed silently [here](https://github.com/amethyst/rustrogueliketutorial/blob/33872fe582f226178436847e1f74eafcbf9c0d1a/chapter-57-ai/src/inventory_system.rs#L83-L85) and [here](https://github.com/amethyst/rustrogueliketutorial/blob/33872fe582f226178436847e1f74eafcbf9c0d1a/chapter-57-ai/src/inventory_system.rs#L93-L95).

It should be mentioned in the text of the tutorial before the part about removing `Monster`.
Also, should there be a replacement check here, like testing if the target as some attributes?

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。