amethyst / amethyst/rustrogueliketutorial

Missing information on removing `Monster`

Aperta
#222 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
970
Fork
166
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

https://github.com/amethyst/rustrogueliketutorial/blob/33872fe582f226178436847e1f74eafcbf9c0d1a/book/src/chapter_57.md?plain=1#L1509

At this point in the tutorial, `Monster` is still used in `inventory_system`.
From what I see in the code repository, checks on wether the target is a monster or not have been removed silently [here](https://github.com/amethyst/rustrogueliketutorial/blob/33872fe582f226178436847e1f74eafcbf9c0d1a/chapter-57-ai/src/inventory_system.rs#L83-L85) and [here](https://github.com/amethyst/rustrogueliketutorial/blob/33872fe582f226178436847e1f74eafcbf9c0d1a/chapter-57-ai/src/inventory_system.rs#L93-L95).

It should be mentioned in the text of the tutorial before the part about removing `Monster`.
Also, should there be a replacement check here, like testing if the target as some attributes?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.