amethyst / amethyst/rustrogueliketutorial

Town buildings are populated in wrong order

Open
#148 1 comment 4 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
970
Forks
166
PR merge metrics
No merged PRs in 30d

Description

My Player got spawned in a building so small, that it didn't even fit _Barkeep_, so I started investigating.

Code in _town.rs/building_factory_ is incorrect. It iterates over original `buildings` array, and uses its index to pick `build_type` form `building_index` array, which was sorted and has different indexing:
```rust
for (i, building) in buildings.iter().enumerate() {
let build_type = &building_index[i].2;
match build_type {
```

It should be changed to something like this:
```rust
for (i, _size, build_type) in building_index.iter() {
let building = &buildings[*i];
match build_type {
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.