amethyst / amethyst/bracket-lib

Numpad keys not working on macOS

Abierto
#222 2 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Rust
Estrellas
1.7k
Forks
126
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Thanks for this library! I've been working my way through your fantastic Hands-on Rust book, but I can't get the numpad keys to work correctly on macOS.

This is what I have found so far, using the numpad8 key as an example

On a mac the scancode for numpad8 is 91

You can see this in the winit mac platform implementation here (0x5b converted to base 10 is 91)
https://github.com/rust-windowing/winit/blob/master/src/platform_impl/macos/event.rs#L185

However, looking at the bracket-lib `virtual_key_code_to_scan` function here I see it mapping to scancode 72 (which I believe is correct for windows)
https://github.com/amethyst/bracket-lib/blob/master/bracket-terminal/src/hal/crossterm_be/scancode_helper.rs#L59

In order to get it working on a mac I think `virtual_key_code_to_scan` would need to be aware of the platform currently running and use different scancodes on a mac?

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.