amethyst / amethyst/bracket-lib

Numpad keys not working on macOS

Open
#222 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1.7k
Forks
126
PR merge metrics
No merged PRs in 30d

Description

Thanks for this library! I've been working my way through your fantastic Hands-on Rust book, but I can't get the numpad keys to work correctly on macOS.

This is what I have found so far, using the numpad8 key as an example

On a mac the scancode for numpad8 is 91

You can see this in the winit mac platform implementation here (0x5b converted to base 10 is 91)
https://github.com/rust-windowing/winit/blob/master/src/platform_impl/macos/event.rs#L185

However, looking at the bracket-lib `virtual_key_code_to_scan` function here I see it mapping to scancode 72 (which I believe is correct for windows)
https://github.com/amethyst/bracket-lib/blob/master/bracket-terminal/src/hal/crossterm_be/scancode_helper.rs#L59

In order to get it working on a mac I think `virtual_key_code_to_scan` would need to be aware of the platform currently running and use different scancodes on a mac?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.