ament / ament/ament_lint

[ament_pep257] make pep257 default in ament_pep257

未關閉
#398 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
backlog
主要語言
Python
星號
50
分支
129
平均合併
3 天 10 小時
30 天內合併 PR
3

描述

It is very confusing that `ament_pep257` does by default NOT check for `pep257`, but instead for some seemingly arbitrary list of pydocstyle error codes, see https://github.com/ament/ament_lint/blob/rolling/ament_pep257/ament_pep257/main.py#L77

Why is some `--convention pep257` parameter necessary to actually really check for `pep257`? In my opinion it should not be called `pep257` if it doesn't check for `pep257` by default.

Does anyone know why this is not the case? I'd create a PR to change the default, but I'm not sure about implications on the ROS2 build farm.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。