amatt13 / amatt13/BossFight

Rework how much gold is awarded for overkill damage

Open
#45 0 comments 0 reactions 0 assignees View on GitHub
Back End good first issue
Dominant language
C#
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

CalculateEarnedGoldForInvolvedPlayers() does not take into effect how much of the damage was overkill damage.
This could be "calculated" by updating the SubtractHealth() function.

Remember to check that DoT effect is also correctly handled.

Should overkill damage be ignored? Should it only award a little bit extra gold?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.