alteryx / alteryx/featuretools

Spike: Improve Generics for Input Types in Primitives

未關閉
#1,686 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Python
星號
7.7k
分支
915
PR 合併指標
30 天內沒有已合併 PR

描述

## Problem
- Certain comparison primitives like Equal, NotEqual, EqualScalar, NotEqualScalar use the ColumnSchema base class in their allowed primitive inputs. This allows them to take accept any Logical Type as input. For the Equal case, the allowed input is defined this way:
```python
input_types = [ColumnSchema(), ColumnSchema()]
```
- This means that valid input could be two numeric features, two text features, or even one text and one numeric feature.
- But we only want to compare two numeric features, two text features. Not the third case.
- We therefore need a way to link two primitive input types.

## Request
- This spike is to create a design document to possible solutions to this problem.

## Related Docs
- https://alteryx.atlassian.net/wiki/spaces/PS/pages/1034519162/Improving+Generic+Variable+Types+in+Primitives
- https://github.com/alteryx/featuretools/issues/845
- https://github.com/alteryx/featuretools/issues/842

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。