alteryx / alteryx/featuretools

Spike: Improve Generics for Input Types in Primitives

未关闭
#1,686 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
7.7k
派生
915
PR 合并指标
30 天内没有已合并 PR

描述

## Problem
- Certain comparison primitives like Equal, NotEqual, EqualScalar, NotEqualScalar use the ColumnSchema base class in their allowed primitive inputs. This allows them to take accept any Logical Type as input. For the Equal case, the allowed input is defined this way:
```python
input_types = [ColumnSchema(), ColumnSchema()]
```
- This means that valid input could be two numeric features, two text features, or even one text and one numeric feature.
- But we only want to compare two numeric features, two text features. Not the third case.
- We therefore need a way to link two primitive input types.

## Request
- This spike is to create a design document to possible solutions to this problem.

## Related Docs
- https://alteryx.atlassian.net/wiki/spaces/PS/pages/1034519162/Improving+Generic+Variable+Types+in+Primitives
- https://github.com/alteryx/featuretools/issues/845
- https://github.com/alteryx/featuretools/issues/842

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。