Refactor LDA/PCA classes
Abierto
refactor
spike
- Lenguaje dominante
- Python
- Estrellas
- 850
- Forks
- 96
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
LDA and PCA have a lot of common code. It seems these could be boiled down to a common base class that has `.fit()` `.fit_transform()` and `.transform()` defined with the individual classes just overriding `__init__()`. It seems that allowing `infer_feature_types()` to handle None is a prerequisite to this.
Is this worthwhile?
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.