alteryx / alteryx/evalml

Refactor LDA/PCA classes

Open
#2,197 0 comments 0 reactions 1 assignee Claimed by @asniyaz View on GitHub
refactor spike
Dominant language
Python
Stars
850
Forks
96
PR merge metrics
No merged PRs in 30d

Description

LDA and PCA have a lot of common code. It seems these could be boiled down to a common base class that has `.fit()` `.fit_transform()` and `.transform()` defined with the individual classes just overriding `__init__()`. It seems that allowing `infer_feature_types()` to handle None is a prerequisite to this.

Is this worthwhile?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.