allure-framework / allure-framework/allure-java
[allure-httpclient] Add request/response attachment from the DataProvider method
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 376
- Forks
- 241
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 45
Description
#### I'm submitting a ...
- [x] bug report
- [x] feature request
- [ ] support request => Please do not submit support request here, see note at the top of this template.
#### What is the current behaviour?
When sending an HTTP request in a Data Provider method, the request/response attachment is not created.
In https://github.com/allure-framework/allure-java/blob/master/allure-java-commons/src/main/java/io/qameta/allure/AllureLifecycle.java#L609 line the error is thrown, the error message is printed in the logs.
#### What is the expected behavior?
An attachment is created from the Data Provider method.
#### What is the motivation/use case for changing the behaviour?
In the case of the data provider request failure, it's hard to find the root cause.
Some significant part of the test case execution log is lost.
#### Please tell us about your environment:
| Allure version | 2.13.2 |
| --- | --- |
| Test framework | testng@7.1 |
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in allure-java-commons/src/main/java/io/qameta/allure/AllureLifecycle.java around line 609, then trace how HTTP request and response attachments are handled during a TestNG DataProvider method. Reproduce a failing DataProvider request and verify that the request/response attachment is created and the relevant execution log is retained.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100