allure-framework / allure-framework/allure-java

[allure-httpclient] Add request/response attachment from the DataProvider method

Open
#458 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
376
Forks
240
Avg merge
1d 7h
Merged PRs (30d)
45

Description

#### I'm submitting a ...
- [x] bug report
- [x] feature request
- [ ] support request => Please do not submit support request here, see note at the top of this template.

#### What is the current behaviour?
When sending an HTTP request in a Data Provider method, the request/response attachment is not created.
In https://github.com/allure-framework/allure-java/blob/master/allure-java-commons/src/main/java/io/qameta/allure/AllureLifecycle.java#L609 line the error is thrown, the error message is printed in the logs.

#### What is the expected behavior?
An attachment is created from the Data Provider method.

#### What is the motivation/use case for changing the behaviour?
In the case of the data provider request failure, it's hard to find the root cause.
Some significant part of the test case execution log is lost.

#### Please tell us about your environment:

| Allure version | 2.13.2 |
| --- | --- |
| Test framework | testng@7.1 |

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.