allegro / allegro/typescript-strict-plugin

CLI didn't catch type errors

未关闭
#72 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
TypeScript
星标
397
派生
34
PR 合并指标
PR 指标待抓取

描述

Hi,
Thanks a lot for the package, it helps us to add strict mode to the project based on lerna monorepo module by module.

Problem:
During react upgrade to v18 we upgraded next packages as well:
```
"@testing-library/dom": "9.3.1" -> "9.3.3",
"@testing-library/jest-dom": "5.16.5" -> "6.2.0",
"@testing-library/react": "11.2.7" -> "14.1.2",
"@testing-library/user-event": "14.4.3" -> "14.5.2"
```
After that, script `"typecheck": "tsc-strict --noEmit --incremental false"` runs successfully, despite type errors (IDE still shows errors).
I found out that update of the listed packages to specific versions:
```
`@testing-library/jest-dom: 6.x.x`
"@testing-library/user-event": 14.5.x
```
breaks cli check.
We are using package-lock file in project.
Re-generating package-lock breaks cli as well, but there are too much changes to define a problem.

Any thought will be helpful. Thanks in advance

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。