allegro / allegro/typescript-strict-plugin

CLI didn't catch type errors

Abierto
#72 1 comentario 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
397
Forks
34
Métricas de merge de PR
Métricas de PR pendientes

Descripción

Hi,
Thanks a lot for the package, it helps us to add strict mode to the project based on lerna monorepo module by module.

Problem:
During react upgrade to v18 we upgraded next packages as well:
```
"@testing-library/dom": "9.3.1" -> "9.3.3",
"@testing-library/jest-dom": "5.16.5" -> "6.2.0",
"@testing-library/react": "11.2.7" -> "14.1.2",
"@testing-library/user-event": "14.4.3" -> "14.5.2"
```
After that, script `"typecheck": "tsc-strict --noEmit --incremental false"` runs successfully, despite type errors (IDE still shows errors).
I found out that update of the listed packages to specific versions:
```
`@testing-library/jest-dom: 6.x.x`
"@testing-library/user-event": 14.5.x
```
breaks cli check.
We are using package-lock file in project.
Re-generating package-lock breaks cli as well, but there are too much changes to define a problem.

Any thought will be helpful. Thanks in advance

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.