alexellis / alexellis/k3sup

Add --data-dir as a flag instead of passing it via --k3s-extra-args

Ouverte
#389 2 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
Langage dominant
Go
Étoiles
7.4k
Forks
430
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

## Expected Behaviour

It would be convenient to have a flag for `--data-dir` in the k3sup install and join commands.

## Current Behaviour

A longer flag is required:

`--k3s-extra-args="--data-dir=/mnt/ssd/k3s"`

## Possible Solution

You don't need an SSD to test this, the command just installs k3s into a custom path for its data.

Make --data-dir output additional arguments to k3s-extra-args, as per other flags we already have that work this way.

Bear in mind that there is a `setupAdditionalServer` and `setupAgent` function, both of which work in a very similar way.

## Context

Thought of this whilst looking into #373

There also appears to be a bug in the join command which means extra args are ignored due to the ordering of string concatenation?

![Screenshot from 2022-08-26 11-38-26](https://user-images.githubusercontent.com/6358735/186886746-0f60661d-e49e-4e7c-8b6a-439c2e0c349a.png)

Related to: https://github.com/alexellis/k3sup/pull/388

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.