alexellis / alexellis/k3sup

Add --data-dir as a flag instead of passing it via --k3s-extra-args

Offen
#389 2 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Go
Sterne
7.4k
Forks
430
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

## Expected Behaviour

It would be convenient to have a flag for `--data-dir` in the k3sup install and join commands.

## Current Behaviour

A longer flag is required:

`--k3s-extra-args="--data-dir=/mnt/ssd/k3s"`

## Possible Solution

You don't need an SSD to test this, the command just installs k3s into a custom path for its data.

Make --data-dir output additional arguments to k3s-extra-args, as per other flags we already have that work this way.

Bear in mind that there is a `setupAdditionalServer` and `setupAgent` function, both of which work in a very similar way.

## Context

Thought of this whilst looking into #373

There also appears to be a bug in the join command which means extra args are ignored due to the ordering of string concatenation?

![Screenshot from 2022-08-26 11-38-26](https://user-images.githubusercontent.com/6358735/186886746-0f60661d-e49e-4e7c-8b6a-439c2e0c349a.png)

Related to: https://github.com/alexellis/k3sup/pull/388

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.