akveo / akveo/ng2-smart-table

rxjs slim import

未關閉
#55 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
TypeScript
星號
1.6k
分支
867
PR 合併指標
30 天內沒有已合併 PR

描述

I notice there are code where rxjs Subject and Observable are imported, they're being brought in from 'rxjs/Rx'

`import { Subject, Observable } from 'rxjs/Rx';`

Is there a reason these can't be brought in from their respective areas within rxjs?

```
import { Subject } from 'rxjs/Subject';
import { Observable } from 'rxjs/Observable';
```

I've found that with this change, webpack-dev-server reports the main.bundle is 945k, whereas it was 1.53 MB when using the single line include (packaging much more than just Subject and Observable).

I'm presently trying to consume ng2-smart-table as a package within another project and noticed while trying to profile my webpack builds that all of rxjs seemed to be included somewhere.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。