akveo / akveo/ng2-smart-table

rxjs slim import

Aberta
#55 0 comentários 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
TypeScript
Estrelas
1.6k
Forks
867
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

I notice there are code where rxjs Subject and Observable are imported, they're being brought in from 'rxjs/Rx'

`import { Subject, Observable } from 'rxjs/Rx';`

Is there a reason these can't be brought in from their respective areas within rxjs?

```
import { Subject } from 'rxjs/Subject';
import { Observable } from 'rxjs/Observable';
```

I've found that with this change, webpack-dev-server reports the main.bundle is 945k, whereas it was 1.53 MB when using the single line include (packaging much more than just Subject and Observable).

I'm presently trying to consume ng2-smart-table as a package within another project and noticed while trying to profile my webpack builds that all of rxjs seemed to be included somewhere.

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.