airvzxf / airvzxf/ftp-deployment-action

test(smoke): smoke tests do not cover FTPS (implicit or explicit)

未关闭
#231 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
audit pending-design pending-human priority:low test
主要语言
Shell
星标
37
派生
9
平均合并
44 分钟
30 天内合并 PR
47

描述

gh issue create --title "test(smoke): smoke tests do not cover FTPS (implicit or explicit)" --label "test,audit,priority:low" --body "## Finding

tests/smoke.sh runs the action against a plain FTP server only. FTPS scenarios (03 and 04 in the integration suite) are not exercised by the smoke gate. A FTPS-only regression could pass smoke and break in production.

## Affected code

- tests/smoke.sh
- (maybe a new tests/smoke-ftps.sh)

## Reproduction

1. Inspect tests/smoke.sh: no FTPS test case.

## Suggested fix

Add a smoke test that runs the action with INPUT_FTP_SSL=true and a self-signed cert. Or add a separate tests/smoke-ftps.sh target and wire it into the Makefile.

## Source

F2 audit 2026-09-03 (tests audit). Reporter: subagent-pekodbj7.

## Related

- Part of EPIC #[epic-number]
- Closes: #NONE (no existing issue)
- Related: #120 (FTPS integration coverage — closed, superseded by current scenarios)"

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start by reading tests/smoke.sh and compare its plain FTP coverage with FTPS scenarios 03 and 04 in the integration suite. Check the Makefile to see how smoke targets are wired, then determine whether the FTPS case belongs in tests/smoke.sh or a separate tests/smoke-ftps.sh. Done means the smoke gate runs an FTPS test with INPUT_FTP_SSL=true and a self-signed certificate.

由索引模型根据 Issue 内容生成。

评估

技术栈
github-actions, shell
领域
ci-cd, testing
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
活跃
描述清晰度
基本清楚
新手友好度
72/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。