airvzxf / airvzxf/ftp-deployment-action

test(smoke): smoke tests do not cover FTPS (implicit or explicit)

Ouverte
#231 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
audit pending-design pending-human priority:low test
Langage dominant
Shell
Étoiles
37
Forks
9
Merge moyen
44 min
PR mergées (30 j)
47

Description

gh issue create --title "test(smoke): smoke tests do not cover FTPS (implicit or explicit)" --label "test,audit,priority:low" --body "## Finding

tests/smoke.sh runs the action against a plain FTP server only. FTPS scenarios (03 and 04 in the integration suite) are not exercised by the smoke gate. A FTPS-only regression could pass smoke and break in production.

## Affected code

- tests/smoke.sh
- (maybe a new tests/smoke-ftps.sh)

## Reproduction

1. Inspect tests/smoke.sh: no FTPS test case.

## Suggested fix

Add a smoke test that runs the action with INPUT_FTP_SSL=true and a self-signed cert. Or add a separate tests/smoke-ftps.sh target and wire it into the Makefile.

## Source

F2 audit 2026-09-03 (tests audit). Reporter: subagent-pekodbj7.

## Related

- Part of EPIC #[epic-number]
- Closes: #NONE (no existing issue)
- Related: #120 (FTPS integration coverage — closed, superseded by current scenarios)"

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Start by reading tests/smoke.sh and compare its plain FTP coverage with FTPS scenarios 03 and 04 in the integration suite. Check the Makefile to see how smoke targets are wired, then determine whether the FTPS case belongs in tests/smoke.sh or a separate tests/smoke-ftps.sh. Done means the smoke gate runs an FTPS test with INPUT_FTP_SSL=true and a self-signed certificate.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
github-actions, shell
Domaine
ci-cd, testing
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
Active
Clarté
Plutôt claire
Accessibilité débutants
72/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.