aio-libs / aio-libs/multidict

multidict C Extension Analysis Report

未关闭
#1,306 2 条评论 1 个 reaction 已指派 1 人 已被 @Vizonex 认领 在 GitHub 查看
bug reproducer: present
主要语言
Python
星标
492
派生
129
平均合并
14 小时 28 分钟
30 天内合并 PR
35

描述

I ran a [code analysis tool](https://github.com/devdanzin/cext-review-toolkit) I'm developing on multidict and it generated an interesting report: https://gist.github.com/devdanzin/a36588ae7e2b73f0d85f8a925fb13b3d. It contains issue descriptions, suggested fixes, and reproducers for some of the issues.

From the summary:

> The most critical finding is a **double-free/use-after-free in `md_contains`** and a **crash from swapped format string arguments** in `_err_cannot_fetch`. The iterator and view types are also missing the heap type lifecycle management (`Py_VISIT(Py_TYPE(self))`) that the main dict types correctly implement.

I hope it helps.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。