aio-libs / aio-libs/multidict

multidict C Extension Analysis Report

Aperta
#1,306 2 commenti 1 reazione 1 assegnatario Rivendicata da @Vizonex Vedi su GitHub
bug reproducer: present
Lingua principale
Python
Stelle
492
Fork
129
Merge medio
14h 28m
PR unite (30g)
35

Descrizione

I ran a [code analysis tool](https://github.com/devdanzin/cext-review-toolkit) I'm developing on multidict and it generated an interesting report: https://gist.github.com/devdanzin/a36588ae7e2b73f0d85f8a925fb13b3d. It contains issue descriptions, suggested fixes, and reproducers for some of the issues.

From the summary:

> The most critical finding is a **double-free/use-after-free in `md_contains`** and a **crash from swapped format string arguments** in `_err_cannot_fetch`. The iterator and view types are also missing the heap type lifecycle management (`Py_VISIT(Py_TYPE(self))`) that the main dict types correctly implement.

I hope it helps.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.