aio-libs / aio-libs/aiohttp

Add custom header support to websocket client

オープン
#2,053 コメント 8 件 リアクション 0 件 担当者 0 名 GitHub で見る
enhancement pr-available
主要言語
Python
スター
16.5k
フォーク
2.4k
平均マージ
17時間 22分
マージ済み PR(30日)
212

説明

## Feature

Websocket protocol actually supports custom headers. They are not widely used (afair you cannot access them in webbrowser JS in any reasonable way), but may be important.

I've encountered this issue while developing a WS proxy on aiohttp - proxy naturally wants to achieve best
content 'forwarding' possible.

Current state in aiohttp:

* Server side websocket handler can set headers nicely (as `WebSocketResponse` is inherited from `StreamResponse`);
* Client side `ws_connect()` can pass headers, but it is not documented;
* Websocket response (`ClientWebSocketResponse` class) doesn't allow to access them.

So, it looks like there are 2 things to do:

* Add `.headers` property to ClientWebSocketResponse
* Document `headers` kwarg to `ClientSession.ws_connect()`

**Upd** Motivational example:
Setting cookies in WS handler actually works in chrome, but cannot be proxied by aiohttp for now.

**Upd** about ws_connect
`ws_connect(headers=...)` seems to differ from other `ClientSession` methods as it does not accept list of pairs.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。