aio-libs / aio-libs/aiohttp

Add custom header support to websocket client

Abierto
#2,053 8 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement pr-available
Lenguaje dominante
Python
Estrellas
16.5k
Forks
2.4k
Merge medio
17 h 22 min
PR fusionados (30 d)
212

Descripción

## Feature

Websocket protocol actually supports custom headers. They are not widely used (afair you cannot access them in webbrowser JS in any reasonable way), but may be important.

I've encountered this issue while developing a WS proxy on aiohttp - proxy naturally wants to achieve best
content 'forwarding' possible.

Current state in aiohttp:

* Server side websocket handler can set headers nicely (as `WebSocketResponse` is inherited from `StreamResponse`);
* Client side `ws_connect()` can pass headers, but it is not documented;
* Websocket response (`ClientWebSocketResponse` class) doesn't allow to access them.

So, it looks like there are 2 things to do:

* Add `.headers` property to ClientWebSocketResponse
* Document `headers` kwarg to `ClientSession.ws_connect()`

**Upd** Motivational example:
Setting cookies in WS handler actually works in chrome, but cannot be proxied by aiohttp for now.

**Upd** about ws_connect
`ws_connect(headers=...)` seems to differ from other `ClientSession` methods as it does not accept list of pairs.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.