aio-libs / aio-libs/aiohttp

Expose `_RequestOptions` as a public member

Aperta
#11,385 4 commenti 1 reazione 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
Python
Stelle
16.5k
Fork
2.4k
Merge medio
17h 22m
PR unite (30g)
212

Descrizione

### Is your feature request related to a problem?

I'd like to add type annotations for functions that accept keyword arguments that are passed to the `ClientSession.request` method. aiohttp has a TypedDict for this already, `_Requestoptions` but it's a protected member of the aiohttp.client module (has a leading underscore and is not declared in `__all__`).

### Describe the solution you'd like

Remove the underscore for `_RequestOptions` and add it to the `__all__` list, or create a version of the typed dict that includes the kwargs that are part of the documented API.

### Describe alternatives you've considered

There's probably a good reason why it's private, but I didn't see a GitHub issue that addressed that question. If There's a good reason, document the answer here.

### Related component

Client

### Additional context

_No response_

### Code of Conduct

- [x] I agree to follow the aio-libs Code of Conduct

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.