aio-libs / aio-libs/aiohttp

Expose `_RequestOptions` as a public member

Offen
#11,385 4 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
enhancement
Vorherrschende Sprache
Python
Sterne
16.5k
Forks
2.4k
Ø Merge
17 Std. 22 Min.
Gemergte PRs (30 T.)
212

Beschreibung

### Is your feature request related to a problem?

I'd like to add type annotations for functions that accept keyword arguments that are passed to the `ClientSession.request` method. aiohttp has a TypedDict for this already, `_Requestoptions` but it's a protected member of the aiohttp.client module (has a leading underscore and is not declared in `__all__`).

### Describe the solution you'd like

Remove the underscore for `_RequestOptions` and add it to the `__all__` list, or create a version of the typed dict that includes the kwargs that are part of the documented API.

### Describe alternatives you've considered

There's probably a good reason why it's private, but I didn't see a GitHub issue that addressed that question. If There's a good reason, document the answer here.

### Related component

Client

### Additional context

_No response_

### Code of Conduct

- [x] I agree to follow the aio-libs Code of Conduct

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.