agronholm / agronholm/sqlacodegen

Use logging instead of print for informational statements

Ouverte
#451 5 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
Python
Étoiles
2.4k
Forks
284
Merge moyen
2 j 1 h
PR mergées (30 j)
1

Description

### Things to check first

- [x] I have searched the existing issues and didn't find my feature already requested there

### Feature description

https://github.com/agronholm/sqlacodegen/blob/615d79c6f6fdcb776c891179eb46516b1e8fd6f5/src/sqlacodegen/cli.py#L143 defaults to using stdout but the print statements above corrupt the stdout file by printing a bunch of logging statements

https://github.com/agronholm/sqlacodegen/blob/615d79c6f6fdcb776c891179eb46516b1e8fd6f5/src/sqlacodegen/cli.py#L94-L129

Instead, there should be a way to configure Logging to redirect the `print` statements to somewhere else (or suppress them altogether!)

### Use case

1. `sqlacodegen` command which redirects stdout to a generated file (ex: from a docker exec command)
2. Do anything which causes one of the `print` statements to fire, like use pgvector.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.