agronholm / agronholm/sqlacodegen

Use logging instead of print for informational statements

Open
#451 5 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
2.4k
Forks
284
Avg merge
2d 1h
Merged PRs (30d)
1

Description

### Things to check first

- [x] I have searched the existing issues and didn't find my feature already requested there

### Feature description

https://github.com/agronholm/sqlacodegen/blob/615d79c6f6fdcb776c891179eb46516b1e8fd6f5/src/sqlacodegen/cli.py#L143 defaults to using stdout but the print statements above corrupt the stdout file by printing a bunch of logging statements

https://github.com/agronholm/sqlacodegen/blob/615d79c6f6fdcb776c891179eb46516b1e8fd6f5/src/sqlacodegen/cli.py#L94-L129

Instead, there should be a way to configure Logging to redirect the `print` statements to somewhere else (or suppress them altogether!)

### Use case

1. `sqlacodegen` command which redirects stdout to a generated file (ex: from a docker exec command)
2. Do anything which causes one of the `print` statements to fire, like use pgvector.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.