agilgur5 / agilgur5/trim-canvas

Add optional arg to duplicate / clone canvas

Đang mở
#6 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
feature
Ngôn ngữ chính
JavaScript
Star
74
Fork
5
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

i.e. `trimCanvas(canvas, {duplicate: true})`.

Given the intense demand seen by the number of upvotes on https://github.com/szimek/signature_pad/issues/49#issuecomment-260976909 it seems like it should be included by default.

I'm also reading through my own docs for the first time in a while and if you don't know how canvas or cloning works, it may be quite unintuitive.

It's only a handful of lines of code, but IIRC the reason why I didn't include it (or removed it rather) was because it introduced a dependency on `canvas`, meaning it wouldn't work in Node (requires a pretty massive native dependency). If it's hidden behind an optional flag though, this shouldn't be problematic.
This is something I've been thinking of adding for a while (in my backlog, ofc), but I also happened to see https://github.com/lukechilds/merge-images#nodejs-usage today, which is another interesting workaround for Node usage.

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.