ageron / ageron/handson-ml

using column indices in the Custom Transformer

未關閉
#615 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Jupyter Notebook
星號
25.6k
分支
12.7k
PR 合併指標
PR 指標待擷取

描述

In command line 68 and 69 of the projectcode of Chapter 2, the column indices of rooms_ix, bedrooms_ix, population_ix, household_ix are calculated using the whole 'housing' df. These column indices are later used in the custom Transformer.

Shouldn't this be the indices of the subset of the housing df that is used in the Columntransformer?

(For the current project it does't matter because indices are the same, but just for the conveniece and clearity)

Kind regards

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。