ageron / ageron/handson-ml

using column indices in the Custom Transformer

Abierto
#615 1 comentario 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Jupyter Notebook
Estrellas
25.6k
Forks
12.7k
Métricas de merge de PR
Métricas de PR pendientes

Descripción

In command line 68 and 69 of the projectcode of Chapter 2, the column indices of rooms_ix, bedrooms_ix, population_ix, household_ix are calculated using the whole 'housing' df. These column indices are later used in the custom Transformer.

Shouldn't this be the indices of the subset of the housing df that is used in the Columntransformer?

(For the current project it does't matter because indices are the same, but just for the conveniece and clearity)

Kind regards

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.