agentscope-ai / agentscope-ai/agentscope-java

[Bug]: edit_file hangs indefinitely when old_string is empty

未关闭
#2,446 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
area/core/agent bug
主要语言
Java
星标
5.6k
派生
1.3k
平均合并
4 天 12 小时
30 天内合并 PR
77

描述

Calling edit_file with an empty old_string never returns.

Reproduction:

filesystem.edit(runtimeContext, "/notes.md", "", "replacement", false);

The loop in FilesystemUtils.countOccurrences() calls indexOf("", idx).
Because the empty string has length 0, idx never advances and the loop runs forever.

Expected behavior:
Return a normal validation error such as:
"old_string must not be empty"

Suggested fix:
Validate oldString before countOccurrences() and add a unit test with a timeout assertion.

This should be a small backward-compatible fix with no API change.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。