agentscope-ai / agentscope-ai/agentscope-java
[Bug]: edit_file hangs indefinitely when old_string is empty
Offen
area/core/agent
bug
- Vorherrschende Sprache
- Java
- Sterne
- 5.6k
- Forks
- 1.3k
- Ø Merge
- 4 T. 12 Std.
- Gemergte PRs (30 T.)
- 77
Beschreibung
Calling edit_file with an empty old_string never returns.
Reproduction:
filesystem.edit(runtimeContext, "/notes.md", "", "replacement", false);
The loop in FilesystemUtils.countOccurrences() calls indexOf("", idx).
Because the empty string has length 0, idx never advances and the loop runs forever.
Expected behavior:
Return a normal validation error such as:
"old_string must not be empty"
Suggested fix:
Validate oldString before countOccurrences() and add a unit test with a timeout assertion.
This should be a small backward-compatible fix with no API change.
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.