agent-substrate / agent-substrate/substrate

ImagePullSecrets in actor templates

未關閉
#868 4 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
area/api area/node kind/feature
主要語言
Go
星號
1.8k
分支
316
平均合併
2 天 43 分鐘
30 天內合併 PR
287

描述

Right now, you can only auth to google artifact registry. We should add support for pulling from arbitrary private registry with `ImagePullSecrets` on the ActorTemplate. I think the main question is who should resolve the secret? Atelet or ate-api. I'm leaning towards `atelet` much like how kubelet resolve's secret. This however does put a kube apiserver call in the golden image creation path, which is probably fine. Also, we can add a secret cache since I would guess that there aren't that many image pull secrets in a cluster.

The one thing to watch out for is that the atelet kubernetes service account is going to need configuration to access the referenced secrets.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。