agent-substrate / agent-substrate/substrate

ImagePullSecrets in actor templates

Aberta
#868 4 comentários 0 reações 0 responsáveis Ver no GitHub
area/api area/node kind/feature
Linguagem predominante
Go
Estrelas
1.8k
Forks
316
Merge médio
2d 43min
PRs com merge (30d)
287

Descrição

Right now, you can only auth to google artifact registry. We should add support for pulling from arbitrary private registry with `ImagePullSecrets` on the ActorTemplate. I think the main question is who should resolve the secret? Atelet or ate-api. I'm leaning towards `atelet` much like how kubelet resolve's secret. This however does put a kube apiserver call in the golden image creation path, which is probably fine. Also, we can add a secret cache since I would guess that there aren't that many image pull secrets in a cluster.

The one thing to watch out for is that the atelet kubernetes service account is going to need configuration to access the referenced secrets.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.