agent-substrate / agent-substrate/substrate

Add ate.actors gauge

未关闭
#796 33 条评论 0 个 reaction 已指派 1 人 已被 @krisztianfekete 认领 在 GitHub 查看
area/observability kind/feature
主要语言
Go
星标
1.8k
派生
316
平均合并
2 天 43 分钟
30 天内合并 PR
287

描述

#433 shipped everything, except `ate.actors`, opening this one so we can chat about the design and it doesn't get lost.

Now we can now see pool saturation, lifecycle latency, scheduling outcomes and cold start phases, but nothing says how many actors exist and what state they're in.

Original idea for `ate.actors` was an observable updowncounter labelled by status and template. Both bounded, so it's fine cardinality-wise.

The problem is that a metric callback runs on every collection interval, and a scan across ~1B actors every interval isn't something we can (or at least should) do. So we need something cheaper, e.g. a store maintained counters incremented on status transitions, or a separate actor index. That's more like a store design question and I'd rather discuss it first.

One related thing is addressing the new `ate.actor.crashes` metric that counts crashes as they happen. This would count actors that are in CRASHED right now. Both are useful, but we should say which is which so operators are aware.

cc @JeffLuoo @maxsmythe @juli4n @EItanya @git286

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。