agent-substrate / agent-substrate/substrate

Add ate.actors gauge

Aperta
#796 33 commenti 0 reazioni 1 assegnatario Rivendicata da @krisztianfekete Vedi su GitHub
area/observability kind/feature
Lingua principale
Go
Stelle
1.8k
Fork
316
Merge medio
2g 43m
PR unite (30g)
287

Descrizione

#433 shipped everything, except `ate.actors`, opening this one so we can chat about the design and it doesn't get lost.

Now we can now see pool saturation, lifecycle latency, scheduling outcomes and cold start phases, but nothing says how many actors exist and what state they're in.

Original idea for `ate.actors` was an observable updowncounter labelled by status and template. Both bounded, so it's fine cardinality-wise.

The problem is that a metric callback runs on every collection interval, and a scan across ~1B actors every interval isn't something we can (or at least should) do. So we need something cheaper, e.g. a store maintained counters incremented on status transitions, or a separate actor index. That's more like a store design question and I'd rather discuss it first.

One related thing is addressing the new `ate.actor.crashes` metric that counts crashes as they happen. This would count actors that are in CRASHED right now. Both are useful, but we should say which is which so operators are aware.

cc @JeffLuoo @maxsmythe @juli4n @EItanya @git286

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.