agent-substrate / agent-substrate/substrate
Dev scripts shouldn't require clang-format to be installed locally
Aberta
area/dev-infra
kind/cleanup
- Linguagem predominante
- Go
- Estrelas
- 1.8k
- Forks
- 316
- Merge médio
- 2d 43min
- PRs com merge (30d)
- 287
Descrição
We shouldn't assume tools are locally installed as that introduces friction, but more importantly, makes the dev env non hermetic. In general we use `go tools` (with a dedicated Go module under `hack/tools` for isolation) for tools that can be distributed with go modules, and for those that can't (like clang-format), we have as script that fetches a pinned version (see protoc as an example[1]).
[1]: https://github.com/agent-substrate/substrate/blob/381b3ad52ca7dbf04e453872a3acfe2d6bd4cbd0/hack/protoc.sh#L21
Guia de contribuição
Avaliação
Esta issue ainda não foi avaliada.