agent-substrate / agent-substrate/substrate

Dev scripts shouldn't require clang-format to be installed locally

Abierto
#457 0 comentarios 0 reacciones 0 asignados Ver en GitHub
area/dev-infra kind/cleanup
Lenguaje dominante
Go
Estrellas
1.8k
Forks
316
Merge medio
2 d 43 min
PR fusionados (30 d)
287

Descripción

We shouldn't assume tools are locally installed as that introduces friction, but more importantly, makes the dev env non hermetic. In general we use `go tools` (with a dedicated Go module under `hack/tools` for isolation) for tools that can be distributed with go modules, and for those that can't (like clang-format), we have as script that fetches a pinned version (see protoc as an example[1]).

[1]: https://github.com/agent-substrate/substrate/blob/381b3ad52ca7dbf04e453872a3acfe2d6bd4cbd0/hack/protoc.sh#L21

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.