agent-substrate / agent-substrate/substrate

Dev scripts shouldn't require clang-format to be installed locally

Offen
#457 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
area/dev-infra kind/cleanup
Vorherrschende Sprache
Go
Sterne
1.8k
Forks
316
Ø Merge
2 T. 43 Min.
Gemergte PRs (30 T.)
287

Beschreibung

We shouldn't assume tools are locally installed as that introduces friction, but more importantly, makes the dev env non hermetic. In general we use `go tools` (with a dedicated Go module under `hack/tools` for isolation) for tools that can be distributed with go modules, and for those that can't (like clang-format), we have as script that fetches a pinned version (see protoc as an example[1]).

[1]: https://github.com/agent-substrate/substrate/blob/381b3ad52ca7dbf04e453872a3acfe2d6bd4cbd0/hack/protoc.sh#L21

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.